-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for deprecation of Authenticator.db #207
Comments
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗 |
JupyterHub will (not sure how soon) deprecate the
Authenticator.db
property, because the lifecycle of that property is a problem, and Authenticators and Spawners generally shouldn't ever need access to the JupyterHub db, and certainly shouldn't have access to a shared session on that db.xref: jupyterhub/jupyterhub#3700
Proposed change
Make NativeAuthenticator's db session independent of the Hub's internal db session. Creating a new Session against the same database (i.e. starting from db_url instead of db) should be fine, especially since NativeAuthenticator's tables are already independent (related to #28, which I think crosses an internal implementation-detail line).
I think this may need some support from JupyterHub to get the necessary info. Worst case: duplicating db_url config from JupyterHub -> NativeAuthenticator. But since the tables are independent, there's actually no reason other than convenience of configuration for the two to share the same db at all, let alone db session.
Alternative options
db_session()
factory API to create a session on the db that isn't shared with JupyterHubWho would use this feature?
All future deployments of JupyterHub with NativeAuthenticator
The text was updated successfully, but these errors were encountered: