Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell toolbar #254

Merged
merged 9 commits into from
Dec 19, 2023
Merged

Cell toolbar #254

merged 9 commits into from
Dec 19, 2023

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Oct 23, 2023

Example to add cell toolbar buttons.

The buttons are displayed or not, depending on the cell type.

Fix #227

@brichet brichet requested a review from jtpio October 23, 2023 13:43
@jtpio
Copy link
Member

jtpio commented Dec 14, 2023

Thanks @brichet, this looks good!

@jtpio
Copy link
Member

jtpio commented Dec 14, 2023

Looks like there are a couple of conflicts.

Also should the new example be listed in the top-level README.md? https:/jupyterlab/extension-examples#develop-by-examples

@brichet
Copy link
Collaborator Author

brichet commented Dec 14, 2023

Thanks @jtpio for looking this.

I rebased and fixed conflicts, and add la ink and a preview in README.

I also fixed 2 broken previews in README.

@brichet
Copy link
Collaborator Author

brichet commented Dec 14, 2023

Tests are failing because jupyterlab/jupyterlab#14838 is not merged yet.

Probably #244 should have wait for it.

@jtpio
Copy link
Member

jtpio commented Dec 14, 2023

Probably #244 should have wait for it.

Right, I don't know why the failure was ignored in that PR.

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 2b9283f into jupyterlab:main Dec 19, 2023
84 of 87 checks passed
@fcollonval
Copy link
Member

Probably #244 should have wait for it.

Right, I don't know why the failure was ignored in that PR.

It is a chicken egg issue - the lab doc reference the example that reference the lab doc.

@fcollonval
Copy link
Member

Feel free to finish up the doc pr on lab.

@brichet brichet deleted the cell-toobar branch December 27, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add a cell toolbar example
3 participants