Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add server unit tests to CI #370

Closed
andrii-i opened this issue Aug 29, 2023 · 1 comment · Fixed by #519
Closed

Add server unit tests to CI #370

andrii-i opened this issue Aug 29, 2023 · 1 comment · Fixed by #519
Labels
enhancement New feature or request testing Quality assurance tests
Milestone
Future

Comments

@andrii-i
Copy link
Collaborator

andrii-i commented Aug 29, 2023 •
edited
Loading

Problem

As mentioned in #211, packages/jupyter-ai/README.md says that "This extension is using Pytest for Python code testing" but there are no meaningful Pytest tests.

Proposed Solution

Add Pytest server unit tests from packages/jupyter-ai/jupyter_ai/tests to CI.
@andrii-i andrii-i added enhancement New feature or request testing Quality assurance tests labels Aug 29, 2023
@JasonWeill JasonWeill added this to the Future milestone Aug 29, 2023
@andrii-i andrii-i changed the title Add server unit tests Add server unit tests to CI Sep 13, 2023
@andrii-i
Copy link
Collaborator Author

#353 added pytest tests. Updating issue to adding them to CI

@andrii-i andrii-i mentioned this issue Dec 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request testing Quality assurance tests
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Run Python unit tests as a part of CI andrii-i/jupyter-ai
2 participants
@andrii-i @JasonWeill