Only add aria-hidden for scale mode (#501)

jupyterlab · Jan 4, 2023 · 17fa5c7 · 17fa5c7
1 parent e4f5ac1
commit 17fa5c7
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/widgets/src/widget.ts b/packages/widgets/src/widget.ts
@@ -423,7 +423,6 @@ export class Widget implements IMessageHandler, IObservableDisposable {
  MessageLoop.sendMessage(this, Widget.Msg.BeforeShow);
  }
  this.clearFlag(Widget.Flag.IsHidden);
- this.node.removeAttribute('aria-hidden');
  this._toggleHidden(false);
 
  if (this.isAttached && (!this.parent || this.parent.isVisible)) {
@@ -451,7 +450,6 @@ export class Widget implements IMessageHandler, IObservableDisposable {
  MessageLoop.sendMessage(this, Widget.Msg.BeforeHide);
  }
  this.setFlag(Widget.Flag.IsHidden);
- this.node.setAttribute('aria-hidden', 'true');
  this._toggleHidden(true);
 
  if (this.isAttached && (!this.parent || this.parent.isVisible)) {
@@ -743,6 +741,7 @@ export class Widget implements IMessageHandler, IObservableDisposable {
  break;
  case Widget.HiddenMode.Scale:
  this.node.style.transform = 'scale(0)';
+ this.node.setAttribute('aria-hidden', 'true');
  break;
  case Widget.HiddenMode.ContentVisibility:
  // @ts-expect-error content-visibility unknown by DOM lib types
@@ -757,6 +756,7 @@ export class Widget implements IMessageHandler, IObservableDisposable {
  break;
  case Widget.HiddenMode.Scale:
  this.node.style.transform = '';
+ this.node.removeAttribute('aria-hidden');
  break;
  case Widget.HiddenMode.ContentVisibility:
  // @ts-expect-error content-visibility unknown by DOM lib types