Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arrow glyphs #151 #252

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Add arrow glyphs #151 #252

merged 1 commit into from
Oct 25, 2021

Conversation

PlatinumCD
Copy link
Contributor

Hi! This is my first time opening a pull request for Lumino. I'm currently writing a Jupyterlab Extension for the company I work at and I'm loving the Jupyterlab ecosystem.

I think the majority of my changes are self explanatory. Here are a few thoughts:

  • The arrow order, left up right down, follows the order of unicode symbols.
  • I transformed line 1118 into multiple lines because it was growing long.
  • I considered changing the 'else if' chain into a switch statement but I did not follow through.

@welcome
Copy link

welcome bot commented Oct 25, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@blink1073 blink1073 added the enhancement New feature or request label Oct 25, 2021
blink1073
blink1073 approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! I'll make a release with this later this week.

@blink1073 blink1073 merged commit 2b69b5f into jupyterlab:master Oct 25, 2021
@welcome
Copy link

welcome bot commented Oct 25, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

This was referenced Oct 30, 2021
Closed
Closed
krassowski
krassowski reviewed Oct 30, 2021
View reviewed changes
packages/commands/src/index.ts
Comment on lines +1232 to +1243
if (parts.arrowLeft) {
mods += '\u2190 ';
}
if (parts.arrowUp) {
mods += '\u2191 ';
}
if (parts.arrowRight) {
mods += '\u2192 ';
}
if (parts.arrowDown) {
mods += '\u2193 ';
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was only added to the Mac condition, this means that as-is the arrows are not displayed on other operating systems at all. I will fix that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See 526b143.

This was referenced Oct 31, 2021
Closed
Closed
@jasongrout
Copy link
Contributor

I added some more context and thoughts at #151 (comment), since that seems like the best place to consolidate the conversation across #151, #252, #255, and #256.

@jasongrout jasongrout mentioned this pull request Nov 2, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krassowski krassowski krassowski left review comments

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PlatinumCD @jasongrout @blink1073 @krassowski