Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent opening an empty menu #277

Merged
merged 3 commits into from
Dec 31, 2021
Merged

Conversation

hbcarlos
Copy link
Member

Solves jupyterlab/jupyterlab#11650

As commented in jupyterlab/jupyterlab#11650 (comment), there is a minor glitch on the menu when it is empty.
This PR prevents the menu bar from adding a menu to the DOM if the menu is empty.

@hbcarlos
Copy link
Member Author

I also added an empty menu in one of the examples.

@hbcarlos hbcarlos self-assigned this Dec 29, 2021
@hbcarlos hbcarlos added the bug Something isn't working label Dec 29, 2021
@fcollonval
Copy link
Member

Would you mind adding a test too for this?

@hbcarlos
Copy link
Member Author

Sure. I'll add tests.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@blink1073 blink1073 merged commit bf8ccff into jupyterlab:main Dec 31, 2021
@hbcarlos hbcarlos deleted the empty-menu branch January 1, 2022 15:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants