Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a test to check the add tab button has a role of button #631

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

m158261
Copy link
Contributor

@m158261 m158261 commented Sep 11, 2023

References

Related PR - #615

Code changes

Added a test to check the add tab button has a role of button. This allows the user to tab to it using a keyboard.

User-facing changes

None

Backwards-incompatible changes

None

@krassowski krassowski added the maintenance Dependencies, build, technical debt, etc. label Sep 11, 2023
@m158261 m158261 marked this pull request as ready for review September 11, 2023 13:50
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @m158261

@krassowski krassowski merged commit 5df636f into jupyterlab:main Sep 13, 2023
17 of 18 checks passed
@welcome
Copy link

welcome bot commented Sep 13, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance Dependencies, build, technical debt, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants