Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 make title/tabbar's close icon/class customable. #669

Closed
wants to merge 2 commits into from

Conversation

novrain
Copy link
Contributor

@novrain novrain commented Dec 15, 2023

The lumino default theme require font-awsome, but in some project, such as Vue project, they donot use it.
Then the close icon will not show correctly. Import font-awsome to make the SINGLE icon show correctly does't make sences.

changes:

  • provide the same api like title.icon, make the close icon customable

@novrain novrain reopened this Dec 15, 2023
@novrain novrain removed their assignment Dec 16, 2023
@novrain
Copy link
Contributor Author

novrain commented Dec 23, 2023

anything that I can do to make this request be accepted?

@fcollonval, could you please help me?

@krassowski
Copy link
Member

Could you instead override renderCloseIcon in a subclass? This way we would not need to extend the API. This is what JupyterLab does here.

@novrain
Copy link
Contributor Author

novrain commented Jan 9, 2024

Could you instead override renderCloseIcon in a subclass? This way we would not need to extend the API. This is what JupyterLab does here.

Thank you! That's a great option. I will try it.

@fcollonval
Copy link
Member

Hey @novrain I'm closing this as answered with alternative. Let me know if you still need some changes for your use case.

@fcollonval fcollonval closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants