Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly feature stdsimd has been removed #61

Closed
jayvdb opened this issue Feb 12, 2024 · 1 comment · Fixed by #62
Closed

Nightly feature stdsimd has been removed #61

jayvdb opened this issue Feb 12, 2024 · 1 comment · Fixed by #62

Comments

@jayvdb
Copy link

jayvdb commented Feb 12, 2024

The commit removing stdsimd is rust-lang/rust@ea37e80

Relevant tracking issues? rust-lang/rust#27731 and rust-lang/rust#48556

@BrettForr
Copy link

Hi, sorry I'm new to the space so don't know conventions etc. What's the path to resolving this? Is it work to do in this crate or something that needs to be done with nightly rust? I tried switching to an earlier version of nightly rust but that caused some other things to break for me, so wondering if I should keep going down that path or wait for a soon-coming fix.

lazyky added a commit to lazyky/argminmax that referenced this issue Feb 19, 2024
lazyky added a commit to lazyky/argminmax that referenced this issue Feb 19, 2024
@jvdd jvdd closed this as completed in #62 Feb 21, 2024
jvdd added a commit that referenced this issue Feb 21, 2024
* fix: remove `stdsimd` feature; add `stdarch_x86_avx512`

Closes #61

* fix: split the stdsimd feature

* use cfg_version to allow backwards compatible SIMD features

* 🙈 check for nightly feature before enabling cfg_version

* 🧹

* :clown:

* bundle arm features together

---------

Co-authored-by: jvdd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants