-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix K3s golang test Cache Thrashing #9494
Labels
Comments
dereknola
changed the title
Fix K3s Build Cache Thrashing
Fix K3s Unit test Cache Thrashing
Feb 14, 2024
dereknola
changed the title
Fix K3s Unit test Cache Thrashing
Fix K3s golang test Cache Thrashing
Feb 14, 2024
This was referenced Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
The unit test and integration test workflows utilized the default caching provided by the
setup-go
action. However, due to limitations around cache access this is a non optimal use of the cache. Every PR is generating their own cache and throwing out the actually useful cache provide bymaster
branch. You can see this in the current cache.Describe the solution you'd like
What actually needs to happen is:
Master run build-k3s on merge commits, and build a cache of golang depedencies. Only master branch can SAVE a new cache entry
All PRs/non master branches can only RESTORE cache entries for golang. This prevents an overflow of the 10GB cache with entries that can never be used again.
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: