Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with etcd node name missing hostname #9522

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

brandond
Copy link
Member

@brandond brandond commented Feb 16, 2024

Proposed Changes

  • Set ServerNodeName in snapshot CLI setup
  • Raise error if ServerNodeName ends up empty some other way
  • Fix status controller to use etcd node name annotation instead of prefix checking

Types of Changes

bugfix

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

@brandond brandond requested a review from a team as a code owner February 16, 2024 18:19
dereknola
dereknola previously approved these changes Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 42.93%. Comparing base (fa37d03) to head (764d85c).

Files Patch % Lines
pkg/etcd/etcd.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9522      +/-   ##
==========================================
- Coverage   49.32%   42.93%   -6.39%     
==========================================
  Files         154      154              
  Lines       13523    13526       +3     
==========================================
- Hits         6670     5808     -862     
- Misses       5609     6549     +940     
+ Partials     1244     1169      -75     
Flag Coverage Δ
e2etests ?
inttests 39.50% <40.00%> (?)
unittests 15.96% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vitorsavian
vitorsavian previously approved these changes Feb 16, 2024
* Set ServerNodeName in snapshot CLI setup
* Raise errer if ServerNodeName ends up empty some other way
* Fix status controller to use etcd node name annotation instead of prefix checking

Signed-off-by: Brad Davidson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants