-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an integration test for flannel-backend=none #9582
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9582 +/- ##
==========================================
- Coverage 49.44% 42.91% -6.54%
==========================================
Files 151 154 +3
Lines 13471 13523 +52
==========================================
- Hits 6661 5803 -858
- Misses 5467 6552 +1085
+ Partials 1343 1168 -175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4316fb4
to
fd312fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a new section to the E2E startup test, not an entirely new test. If this coverage only concerns server, it should just be an integration test.
Really good point. We can verify this by just using one server, so it could be an integration test. I need to learn how to create one though (sorry, I'm probably going to continue bugging you 🤦 ) |
62dd65e
fd312fd
to
62dd65e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this test to the integration matrix, so it can run in CI. https:/k3s-io/k3s/blob/master/.github/workflows/integration.yaml#L41
62dd65e
to
d2d7dd5
Compare
done! |
43ce692
to
efdeada
Compare
Signed-off-by: Manuel Buil <[email protected]>
efdeada
to
0995e30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https:/k3s-io/k3s/actions/runs/8095641299/job/22123090056?pr=9582 🎉
Ran 1 of 1 Specs in 45.035 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: Test_Integrationflannelnone (45.04s)
PASS
ok github.com/k3s-io/k3s/tests/integration/flannelnone 45.044s
Very nice, thank you for adding this!
Proposed Changes
Add a new test that verifies cluster starts up correclty up to the point where it needs the CNI plugin to continue
Types of Changes
test
Verification
Testing
Linked Issues
User-Facing Change
Further Comments