Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an integration test for flannel-backend=none #9582

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

manuelbuil
Copy link
Contributor

Proposed Changes

Add a new test that verifies cluster starts up correclty up to the point where it needs the CNI plugin to continue

Types of Changes

test

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

@manuelbuil manuelbuil requested a review from a team as a code owner February 27, 2024 10:17
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.91%. Comparing base (86f1021) to head (0995e30).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9582      +/-   ##
==========================================
- Coverage   49.44%   42.91%   -6.54%     
==========================================
  Files         151      154       +3     
  Lines       13471    13523      +52     
==========================================
- Hits         6661     5803     -858     
- Misses       5467     6552    +1085     
+ Partials     1343     1168     -175     
Flag Coverage Δ
e2etests ?
inttests 39.47% <ø> (+0.06%) ⬆️
unittests 15.96% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rancher-max
rancher-max previously approved these changes Feb 27, 2024
Copy link
Member

@dereknola dereknola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a new section to the E2E startup test, not an entirely new test. If this coverage only concerns server, it should just be an integration test.

brandond
brandond previously approved these changes Feb 27, 2024
@brandond brandond self-requested a review February 27, 2024 18:56
@manuelbuil
Copy link
Contributor Author

This should be a new section to the E2E startup test, not an entirely new test. If this coverage only concerns server, it should just be an integration test.

Really good point. We can verify this by just using one server, so it could be an integration test. I need to learn how to create one though (sorry, I'm probably going to continue bugging you 🤦 )

@manuelbuil manuelbuil dismissed stale reviews from brandond and rancher-max via 62dd65e February 28, 2024 14:31
@manuelbuil manuelbuil changed the title Add an e2e test for flannel-backend=none Add an integration test for flannel-backend=none Feb 28, 2024
dereknola
dereknola previously approved these changes Feb 28, 2024
Copy link
Member

@dereknola dereknola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this test to the integration matrix, so it can run in CI. https:/k3s-io/k3s/blob/master/.github/workflows/integration.yaml#L41

@manuelbuil
Copy link
Contributor Author

Please add this test to the integration matrix, so it can run in CI. https:/k3s-io/k3s/blob/master/.github/workflows/integration.yaml#L41

done!

@manuelbuil manuelbuil force-pushed the e2etestflannelnone branch 4 times, most recently from 43ce692 to efdeada Compare February 29, 2024 11:41
Copy link
Contributor

@rancher-max rancher-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https:/k3s-io/k3s/actions/runs/8095641299/job/22123090056?pr=9582 🎉

 Ran 1 of 1 Specs in 45.035 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: Test_Integrationflannelnone (45.04s)
PASS
ok  	github.com/k3s-io/k3s/tests/integration/flannelnone	45.044s

Very nice, thank you for adding this!

@manuelbuil manuelbuil merged commit 736fb2b into k3s-io:master Mar 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants