[Release-1.28] Install and Unit test backports #9641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cache is now on by default Signed-off-by: Derek Nola <[email protected]>
* Remove old cgroupsv2 test * Consolidate install test clauses into functions * Unpin vagrant-k3s plugin version, run latest * Add ubuntu-2204 as install test, remove ubuntu-focal * Update nightly install matrix * Move to Leap 15.5 * Consolidate vagrant box caching key to improve cache hits on all VM testing Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
* Use regular ubuntu runners for install and snapshotter tests * Workaround for vagrant box caching * Update testing readme Signed-off-by: Derek Nola <[email protected]>
* Fix setup-go typos Signed-off-by: Derek Nola <[email protected]>
dereknola
commented
Mar 4, 2024
| - uses: actions/setup-go@v5 | ||
| with: | ||
| go-version-file: 'go.mod' # Just use whatever version is in the go.mod file | ||
| cache: ${{ github.ref == 'refs/heads/master' }} |
There was a problem hiding this comment.
Note: This is intentional, for now we are effectively disabling caching on any non-master branch to see where we land in terms of caching usage (we only have 10GB limit for all caching).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.28 #9641 +/- ##
=================================================
- Coverage 45.21% 26.64% -18.58%
=================================================
Files 154 154
Lines 16685 16685
=================================================
- Hits 7544 4445 -3099
- Misses 7833 11452 +3619
+ Partials 1308 788 -520
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Contains backports of:
#9479
#9480
#9495
#9601
#9634
This is the net effect of:
Types of Changes
Verification
CI Should Pass
Testing
Linked Issues
#9477
User-Facing Change
Further Comments