Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Optimize tests #506

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

spencerdcarlson
Copy link
Contributor

Submitting this MR as an example. What are your thoughts on:

  • leveraging groups to run tests in parallel
  • Making tests repeatable (where it makes sense)
  • Making tests explicitly dependent (where it makes sense)
  • Adding ct:logs

@spencerdcarlson
Copy link
Contributor Author

In the included example, I would prefer to combine the create and delete into one test that first creates and then deletes the same topic instead of passing state between two tests. That would allow for true isolation and parallelism. I did it this way here as an example of what might be the better option for some of the other test modules.

I'm curious if you would welcome me doing some test refactoring to try and make them more explicit, isolated, repeatable, and potentially faster overall execution time.

@zmstone
Copy link
Contributor

zmstone commented May 30, 2022

some of the test cases (integration test with real Kafka) may use the same topic-partitions, e.g. test-topic to send / receive messages.
otherwise running in parallel should work ok.

I'm curious if you would welcome me doing some test refactoring to try and make them more explicit, isolated, repeatable, and potentially faster overall execution time.

Sure, this is very much welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants