Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove use of gRPC buffer pool #898

Merged
merged 1 commit into from
Oct 23, 2024
Merged

chore: remove use of gRPC buffer pool #898

merged 1 commit into from
Oct 23, 2024

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Oct 23, 2024

This change follows up on #894. It removes the use of the gRPC buffer pool, an
experimental feature that will soon be changed in gRPC. This PR ensures #889
compiles successfully.

This change follows up on #894. It removes the use of the gRPC buffer pool, an
experimental feature that will soon be changed in gRPC. This PR ensures #889
compiles successfully.
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.92%. Comparing base (685587a) to head (4040dac).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #898      +/-   ##
==========================================
+ Coverage   66.78%   66.92%   +0.13%     
==========================================
  Files         179      179              
  Lines       21613    21613              
==========================================
+ Hits        14435    14465      +30     
+ Misses       6402     6381      -21     
+ Partials      776      767       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ijsong ijsong merged commit f4eede8 into main Oct 23, 2024
10 checks passed
@ijsong ijsong deleted the rm_buffer_pool_use branch October 23, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant