Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vesting #214

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Vesting #214

wants to merge 5 commits into from

Conversation

audsssy
Copy link
Collaborator

@audsssy audsssy commented May 27, 2022

No description provided.

@vercel
Copy link

vercel bot commented May 27, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
kali-ui ✅ Ready (Inspect) Visit Preview May 27, 2022 at 11:21AM (UTC)

@audsssy
Copy link
Collaborator Author

audsssy commented May 27, 2022

May need to update smart contract logic based on tx errors here.

depositAmount (named amount as input param) in Vesting is only used to calculate rate and rate is what's used to calculate withdrawAmount so we should be able to remove following error checks and do error check on rate instead.
if (amounts[i] > timeDifference) revert InsufficientAmount();
if (amounts[i] % timeDifference != 0) revert AmountNotSpanMultiple();

This is still WIP. Will need to update smart contract to test further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@audsssy