Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It won't work with default "$ctrl" in component view #96

Closed
srokatonie opened this issue Jun 28, 2016 · 7 comments · May be fixed by #98
Closed

It won't work with default "$ctrl" in component view #96

srokatonie opened this issue Jun 28, 2016 · 7 comments · May be fixed by #98

Comments

@srokatonie
Copy link

I was not declaring controllerAs in my component and using default $ctrl in template. sv-root would be just empty div.

After couple of hours I discovered that you have to use controllerAs: 'something' and use it in your template in order to have this directive working.

Hope that helps someone.
@vlio20
Copy link

vlio20 commented Jul 3, 2016

@srokatonie, did you use 1.5 component in your case?

@vlio20 vlio20 mentioned this issue Jul 3, 2016
Open
@srokatonie
Copy link
Author

@vlio20 Yes, Angular 1.5.7

@wuzhitian
Copy link

Thanks a lot! It works! :)

@jacoporicare jacoporicare mentioned this issue Oct 19, 2016
Closed
@alirezamirian
Copy link

Being forced to use controllerAs: "somethingOtherThan$ctrl" is obviously not a good idea. I think sv-part directive should use an isolated scope. to prevent scope collision.

@vlio20
Copy link

vlio20 commented Apr 10, 2017

@srokatonie, why did you close it?

@igal1c0de4n
Copy link

why close??

@igal1c0de4n igal1c0de4n mentioned this issue Apr 23, 2017
Open
@alejandroiglesias
Copy link

alejandroiglesias commented Mar 26, 2018 •
edited
Loading

Stumbled again upon this 😞
It's been a year and a half since this was opened and it seems such a simple fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Now will work with default controllerAs (angular 1.5.x default contr… vlio20/angular-sortable-view
6 participants
@alejandroiglesias @igal1c0de4n @alirezamirian @vlio20 @wuzhitian @srokatonie