deps: upgrade jsonnet and gojsonnet to 0.20.0 #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonincms
changed the title
The related jsonnet changelog are : - https:/google/jsonnet/releases/tag/v0.18.0 - https:/google/jsonnet/releases/tag/v0.19.0 - https:/google/jsonnet/releases/tag/v0.19.1 - https:/google/jsonnet/releases/tag/v0.20.0 Update search_imports function to return bytes according to the v0.19.0 changes mentioned there: https:/google/jsonnet/releases/tag/v0.19.1
|
I rebased the branch onto master and cleaned up unrelated import reordering. |
Thanks @antonincms - can you explain this further? |
|
@ramaro I was hesitant whether to put bytes in JSONNET_CACHE (and encode them only once), or encode when pulling from the cache (as currently done in the PR). I don't really think encode should matter that much from a performance standpoint. |
|
thanks @antonincms ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1005
Proposed Changes
The related jsonnet changelog are :
Update search_imports function to return bytes according to the v0.19.0 changes mentioned there: https:/google/jsonnet/releases/tag/v0.19.1
I hesitated whether to put bytes in cache directly or keeping current logic and encoding only at return.