Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely remove any references to distutils #1183

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

kgaughan
Copy link
Contributor

@kgaughan kgaughan commented May 28, 2024

Fixes #963.

Proposed Changes

Whereas #964 just attempted to replace copy_tree, this replaces all the remaining references to distutils. This ought to make it possible to proceed with #1119 and add Python 3.12 to the test set.

Docs and Tests

  • Tests added (existing tests cover the changes)
  • Updated documentation (internal functional change that doesn't need external docs)

Whereas #964 just attempted to replace copy_tree, this replaces all the
remaining references to distutils. This ought to make it possible to
proceed with #1119 and add Python 3.12 to the test set.

Closes #963.
@kgaughan
Copy link
Contributor Author

Hi! Any chance somebody could take a look at this and at least let the workflows run?

@kgaughan
Copy link
Contributor Author

@ademariag Is there anything you need me to do to allow the checks to run?

@ademariag
Copy link
Contributor

Sorry I midded this, let me see why it's not working

@ademariag ademariag self-requested a review July 5, 2024 17:36
@ademariag ademariag merged commit 746fd75 into kapicorp:master Jul 5, 2024
5 checks passed
@kgaughan kgaughan deleted the remove-distutils branch July 5, 2024 19:17
@kgaughan
Copy link
Contributor Author

kgaughan commented Jul 5, 2024

Thanks for the merge!

@ademariag ademariag mentioned this pull request Aug 17, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

distutils.dir_util.copy_tree will be deprecated soon
3 participants