Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): support other common SQLite file extensions (like .sqlite) #37

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

dbarnett
Copy link
Contributor

Fixes #36.

Copy link

changeset-bot bot commented Feb 25, 2024

🦋 Changeset detected

Latest commit: 9c475f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tablex/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
tablex ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2024 8:13pm

@dbarnett dbarnett changed the title Support other common SQLite file extensions (like .sqlite) fix(ui): support other common SQLite file extensions (like .sqlite) Feb 25, 2024
@dbarnett
Copy link
Contributor Author

Please LMK if I did the changesets thing properly. It created a new file and I didn't find any other .changesets/ file like that but maybe I'm just the use it since you set it up for the repo?

@kareemmahlees
Copy link
Owner

Good job 🎉
You only need to create the changeset file, as you have done, and the workflow will handle the rest.

Otherwise, LGTM 🚀

@kareemmahlees kareemmahlees merged commit 5141cf4 into kareemmahlees:master Feb 26, 2024
8 checks passed
@kareemmahlees kareemmahlees mentioned this pull request Feb 26, 2024
@kareemmahlees
Copy link
Owner

@all-contributors please add @dbarnett for code

Copy link
Contributor

@kareemmahlees

I've put up a pull request to add @dbarnett! 🎉

@dbarnett
Copy link
Contributor Author

Thanks @kareemmahlees !

You only need to create the changeset file, as you have done, and the workflow will handle the rest.

So it's intentional that the changeset files get continuously created and deleted? Nothing I should do any differently in future changes?

And are there any changes too minor to bump as changesets? Is that what the add --empty in the CONTRIBUTING instructions is about?

@kareemmahlees
Copy link
Owner

kareemmahlees commented Feb 26, 2024

Let me explain the workflow in detail:

  • you create a PR with the changes you have made

  • at the end of your work you create a changeset file by running pnpm changeset add, which will create a changeset file with a dummy name under .changesets/

    What are the situations where you don't add an actual changeset?
    If you are updating the docs and/or making changes to the website ( at apps/web ), we don't manage the versions of the website, but in either case, the changesets bot which I have installed in the repo will always check if there is a changeset file or not.
    So to make the bot happy you add an empty changeset file, by running pnpm changeset add --empty which will be automatically deleted when the PR is merged.

  • when I merge your PR, the changeset action will detect a change in the .changesets folder and will automatically create a PR adding the contents of your generated file to the main Changelog file and then delete that generated file.

I will update the docs to be more precise.

I hope this explains a bit, if you have any other questions LMK.

@dbarnett
Copy link
Contributor Author

I hope this explains a bit, if you have any other questions LMK.

Excellent, thanks! If it helps, I sent #41 to clarify several of those things in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQLite driver should support all common SQLite file extensions
2 participants