-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test of 'Expire' header fails in non-english locales #1741
Closed
comdiv opened this issue
Dec 2, 2015
· 0 comments
· May be fixed by saurabharch/HireDot2#2, saurabharch/Breezeblocks#2, saurabharch/reelcool#1, Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Closed
Test of 'Expire' header fails in non-english locales #1741
comdiv opened this issue
Dec 2, 2015
· 0 comments
· May be fixed by saurabharch/HireDot2#2, saurabharch/Breezeblocks#2, saurabharch/reelcool#1, Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In test UTF-8 used, while server returns localized date time with local timezone name in ASCII, so they not match.
Supertest, used in fixture is not very smart (for my test) - it not allow to check header with custom function (it start to check response body and so on) - or may be i'm missed.
Suggest - change string ZERO_DATE to RegExp that will get just mean part of datetime (before GMT) because if it's correct - it's set well - we not require to test RFC encoder itself here - just that expire is set to really-past date.
Have pull request
The text was updated successfully, but these errors were encountered: