Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(config): Check for the correct symbolic link before test:client #3392

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

johnjbarton
Copy link
Contributor

@johnjbarton johnjbarton commented Oct 28, 2019

I've hit this a couple of times but many months apart, enough time to forget. The error is quite
puzzling without some hints.

Fixes #3391

@karmarunnerbot
Copy link
Member

Build karma 48 completed (commit 931579430c by @johnjbarton)

@AppVeyorBot
Copy link

Build karma 2446 completed (commit a485221464 by @johnjbarton)

@karmarunnerbot
Copy link
Member

Build karma 47 completed (commit 931579430c by @johnjbarton)

Copy link
Collaborator

@kyliau kyliau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lock file is needed to pin the dependencies. Was it removed by accident?

@johnjbarton
Copy link
Contributor Author

Thanks! Yes, I meant to revert the change rather than delete it.

PTAL

@karmarunnerbot
Copy link
Member

Build karma 49 completed (commit 140bbd3cea by @johnjbarton)

@AppVeyorBot
Copy link

Build karma 2447 completed (commit 140bbd3cea by @johnjbarton)

@karmarunnerbot
Copy link
Member

Build karma 48 completed (commit 140bbd3cea by @johnjbarton)

@johnjbarton johnjbarton merged commit bfa7741 into karma-runner:master Oct 28, 2019
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grunt test:client failing at HEAD locally.
4 participants