-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong reference website for docs. #4378
Fix wrong reference website for docs. #4378
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4378 +/- ##
==========================================
- Coverage 51.87% 51.87% -0.01%
==========================================
Files 243 243
Lines 24114 24114
==========================================
- Hits 12510 12509 -1
Misses 10922 10922
- Partials 682 683 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
.github/ISSUE_TEMPLATE/question.md
Outdated
@@ -7,7 +7,7 @@ labels: kind/question | |||
|
|||
<!-- Please use this template while asking a new question. Thanks! | |||
Please make sure you have read the FAQ and searched the issue list. | |||
- FAQ: https:/karmada-io/karmada/blob/master/docs/frequently-asked-questions.md | |||
- FAQ: https:/karmada-io/website/blob/main/docs/faq/faq.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- FAQ: https://github.com/karmada-io/website/blob/main/docs/faq/faq.md | |
- FAQ: https://karmada.io/docs/faq |
How about link to the website?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as below.
I would tend to link to the website because the content in a repo might change over time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased.
Also update other place where reference the website repo, besides the CHANGELOG.
Signed-off-by: yanggang <[email protected]>
738bb06
to
7a1185f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Fix wrong reference website for docs.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: