#505 #473 Upgrade kaspa-alloc's mimalloc dependency #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade mimalloc to 0.1.43 implementing the fix by microsoft team.
michaelsutton
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this
This PR closes #505, #473.
How
By upgrading the
mimallocdependency to version0.1.43which uses version2.1.7version of mimalloc.Tests performed
Problems specified in #473 were resolved through a manual test by @blackmennewstyle.
Why do we need it
kaspa-allocuses an outdated dependency ofmimallocrust crate0.1.39which uses the2.1.2version of themimallocimpl by Microsoft.In this outdated dependency there is a problem of compilation on some systems: microsoft/mimalloc#883
This is fixed in a later version of
mimallochence the reason for why we need to upgrade the dependency in thekaspa-alloccrate.