Set the default Args appdir to None #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the change from kaspanet#429 the defaults are now used whenever no value is passed to cli args. appdir default value used to not matter, but now if it's set it makes the datadir be inside the current directory
aspect
approved these changes
Mar 13, 2024
smartgoo
pushed a commit
to smartgoo/rusty-kaspa
that referenced
this pull request
Jun 18, 2024
With the change from kaspanet#429 the defaults are now used whenever no value is passed to cli args. appdir default value used to not matter, but now if it's set it makes the datadir be inside the current directory
D-Stacks
pushed a commit
to D-Stacks/rusty-kaspa
that referenced
this pull request
Jul 12, 2024
With the change from kaspanet#429 the defaults are now used whenever no value is passed to cli args. appdir default value used to not matter, but now if it's set it makes the datadir be inside the current directory
D-Stacks
pushed a commit
to D-Stacks/rusty-kaspa
that referenced
this pull request
Jul 17, 2024
With the change from kaspanet#429 the defaults are now used whenever no value is passed to cli args. appdir default value used to not matter, but now if it's set it makes the datadir be inside the current directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the change from #429 the defaults are now used whenever no value is passed to cli args.
appdir default value used to not matter, but now if it's set to
Some("datadir")it makes the datadir be inside the current directory - as opposed to the original behavior of it being in~/.rusty-kaspa