Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimap plugin: clear minimap when loading a new track #2479

Closed
othmar52 opened this issue Mar 10, 2022 · 1 comment · Fixed by #2480
Closed

minimap plugin: clear minimap when loading a new track #2479

othmar52 opened this issue Mar 10, 2022 · 1 comment · Fixed by #2480

Comments

@othmar52
Copy link
Contributor

maybe related to issue #617

Wavesurfer.js version(s):

wavesurfer.js 6.0.2

Code needed to reproduce the issue:

open https://wavesurfer-js.org/example/minimap/index.html
open js console and add this line

window.wavesurfer.load('https://ia804502.us.archive.org/13/items/DontWatchTheDJ128BPMDry/Don%27t%20Watch%20The%20DJ%20128BPM%20Dry.mp3');

check minimap during load <-- minimap of previous track still visible until load+analyzing is finished

Shouldn't the minimap be cleared automatically when loading a new track?
or is it necessary to destroy() and initPlugin('minimap') manually?

@thijstriemstra
Copy link
Contributor

or is it necessary to destroy() and initPlugin('minimap') manually?

Think so.

othmar52 added a commit to othmar52/wavesurfer.js that referenced this issue Mar 10, 2022
thijstriemstra pushed a commit that referenced this issue Mar 25, 2022
* minimap plugin: clear waveform when load new audio

@see #2479

* cleanup - remove nested conditions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants