-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Regions] Clicking inside region does not seek #3804
Comments
I've just tested Regions with this example and it seems to work as expected: https://wavesurfer.xyz/examples/?48950705f7944e2406b9e41c9e0152cc Can you create a minimal reproducible code example? |
When I have a chance, I will attempt to create a reproducible code example. However, I was able to confirm that all versions 7.8 and above do not work as expected. Reverting back to 7.7.15 solved the problem. Here is the code snippet that creates the regions:
This snippet is the same regardless of what version of wavesurfer is used. When clicking within a region with 7.7.15, the player seeks to that point in the audio and plays from there. With 7.8.0 and above, nothing happens when I click in a region. The audio continues playing. I am also using the hover plugin. I'm not sure if that would make a difference or not. |
It might be related to the fact that you're setting a custom HTML element in the content. I'll test this use case. |
Since upgrading from 7.7.11 to 7.8.2, seeking no longer works when clicking inside a region. Clicking outside a region works fine. I'm seeing this behavior in both Chrome and Edge. On Firefox, clicking inside a region seeks the audio to that spot, as expected.
Prior to the upgrade, the audio would seek to the correct spot when clicking inside a region on all browsers.
The text was updated successfully, but these errors were encountered: