[Bugfix] Fix ICacheKeySerializerTests flakiness (opensearch-project#1…

…4564) * Fix testInvalidInput flakiness Signed-off-by: Peter Alfonsi <[email protected]> * Addressed andrross's comment Signed-off-by: Peter Alfonsi <[email protected]> * rerun security check Signed-off-by: Peter Alfonsi <[email protected]> --------- Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
kaushalmahi12 · Jul 8, 2024 · ec9d435 · ec9d435
1 parent 153134d
commit ec9d435
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/server/src/test/java/org/opensearch/common/cache/serializer/ICacheKeySerializerTests.java b/server/src/test/java/org/opensearch/common/cache/serializer/ICacheKeySerializerTests.java
@@ -43,10 +43,9 @@ public void testInvalidInput() throws Exception {
  ICacheKeySerializer<BytesReference> serializer = new ICacheKeySerializer<>(keySer);
 
  Random rand = Randomness.get();
- byte[] randomInput = new byte[1000];
- rand.nextBytes(randomInput);
-
- assertThrows(OpenSearchException.class, () -> serializer.deserialize(randomInput));
+ // The first thing the serializer reads is a VInt for the number of dimensions.
+ // This is an invalid input for StreamInput.readVInt(), so we are guaranteed to have an exception
+ assertThrows(OpenSearchException.class, () -> serializer.deserialize(new byte[] { -1, -1, -1, -1, -1 }));
  }
 
  public void testDimNumbers() throws Exception {