Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config.Funcs() #11

Merged
merged 4 commits into from
Mar 26, 2020
Merged

Add config.Funcs() #11

merged 4 commits into from
Mar 26, 2020

Conversation

mashiike
Copy link
Contributor

more simple ref #10
this PR include:

  • create Loader: for co-exist with other settings
  • add config.Funcs() and Loader.Funcs()

Realize replacement other than env and must_env

fujiwara
fujiwara reviewed Mar 26, 2020
View reviewed changes
config.go Outdated
}

var envRepTpl *template.Template
var DefaultLoader *Loader
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DefaultLoader must be a private variable. Because it should not be overwritten from out of a package.

fujiwara
fujiwara approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@fujiwara fujiwara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fujiwara fujiwara merged commit 58d7db8 into kayac:master Mar 26, 2020
@mashiike mashiike deleted the feature/func-map branch March 26, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujiwara fujiwara fujiwara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mashiike @fujiwara