Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop auto block PRs #18

Closed
liangyuanpeng opened this issue Mar 14, 2024 · 5 comments
Closed

Stop auto block PRs #18

liangyuanpeng opened this issue Mar 14, 2024 · 5 comments

Comments

@liangyuanpeng
Copy link

liangyuanpeng commented Mar 14, 2024

Enhancement

Now, the PR will auto block by github action bot and the reason is KCL using github action of CLA to access and update information.

I have tested on my fork repo : https:/liangyuanpeng/kpm/pulls?q=is%3Apr+is%3Aclosed

The first PR is working for reproduce auto block PR. And then PR would not be auto block after i delete the github action CLA,

For CLA, maybe you can try to https:/cla-assistant/cla-assistant?tab=readme-ov-file#setup-your-own-instance-of-cla-assistant

@Peefy @zong-zhe


Summary

Set lock-pullrequest-aftermerge to false for disable auto block PR, you can find it at .github/workflows/cla.yaml

-          lock-pullrequest-aftermerge: True
+          lock-pullrequest-aftermerge: false
@Peefy
Copy link
Contributor

Peefy commented Mar 14, 2024

Thank you for the feedback.

https:/kcl-lang/kpm/blob/main/.github/workflows/cla.yml#L22 Do you mean this option? Sorry, I didn't notice it before. I should have deleted this configuration to solve the problem of automatic locking of the GitHub bot.

@Peefy
Copy link
Contributor

Peefy commented Mar 14, 2024

It works fine in this PR kcl-lang/modules#123 Thank you! ❤️

@Nivedita-coder
Copy link

Hey @liangyuanpeng @Peefy,
Is this issue still open, if yes, I would like to work on it!! 🙌

@d4v1d03
Copy link

d4v1d03 commented Apr 6, 2024

Hey @Peefy , sorry it's been time i lost track of this issue, have made the PRs for the open issues, for the kcl-openapi one, there was no need of changing as the "lock-pullrequest-aftermerge" was already set to false.

@liangyuanpeng
Copy link
Author

@Nivedita-coder
Sorry for the out of sync information, it's resolved.

@d4v1d03
Thanks for your confirm that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants