Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrate to IntelliJ Platform Plugin #44

Merged
merged 6 commits into from
Oct 12, 2024

Conversation

RehanChalana
Copy link
Contributor

@RehanChalana RehanChalana commented Oct 11, 2024

  • use new IntellijPlatform syntax in build.gradle.kts
  • bump to lsp4ij:0.6.0
  • bump to gradleVersion 8.10.0

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

build.gradle.kts
gradle.properties
gradle/libs.versions.toml

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

I have tried migrating from gradle Intellij plugin (1.x) to newer IntelliJ platform Plugin. But as i am not good with gradle tasks, i hope someone can please look into that and help me point in the right direction.

We should also add gradle properties like sinceBuild and updateBuild i am not really sure about them.

I was also trying to add the new syntax for "runIdeForUiTest" task, but again i am not sure about that.

So yes this pr really needs a review from someone !.

Also can you please give it a "hacktoberfest-accepted" tag, it will help me complete the hacktober-fest challenge

- use new IntellijPlatform syntax in build.gradle.kts
- bump to lsp4ij:0.6.0
- bump to gradleVersion 8.10.0

Signed-off-by: rehan <[email protected]>
@RehanChalana
Copy link
Contributor Author

@He1pa @Peefy can you please look into it.

@He1pa
Copy link
Contributor

He1pa commented Oct 11, 2024

Do you have any documentation about sinceBuild and updateBuild or where did you refer to this migration? Previously we had

pluginSinceBuild = 221
 # pluginUntilBuild = 233.*

in gradle.properties. It means supported build number ranges and IntelliJ Platform versions
We set a minimum version but no maximum version to be compatible with subsequent new versions.
I am not sure if this means the same property

@He1pa He1pa self-requested a review October 12, 2024 07:14
@RehanChalana RehanChalana marked this pull request as ready for review October 12, 2024 08:26
build.gradle.kts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: rehan <[email protected]>
…gin' into migrate_to_Intellij_Platform_Plugin

# Conflicts:
#	README.md
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@He1pa He1pa merged commit 910f67c into kcl-lang:main Oct 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants