Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: override union and insert config #1525

Merged
merged 1 commit into from
Jul 30, 2024
Merged

feat: override union and insert config #1525

merged 1 commit into from
Jul 30, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jul 30, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Closes #1502

  • feat: override union and insert config

@Peefy Peefy force-pushed the feat-override-union-config branch from 50c9515 to 8283568 Compare July 30, 2024 05:29
@coveralls
Copy link
Collaborator

coveralls commented Jul 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10156694317

Details

  • 149 of 219 (68.04%) changed or added relevant lines in 3 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 70.305%
Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/ast/src/path.rs 1 9 11.11%
kclvm/query/src/override.rs 138 200 69.0%
Files with Coverage Reduction New Missed Lines %
kclvm/query/src/override.rs 1 82.52%
kclvm/version/src/lib.rs 8 27.27%
Totals Coverage Status
Change from base Build 10138259063: -0.04%
Covered Lines: 54176
Relevant Lines: 77058
💛 - Coveralls

zong-zhe
zong-zhe approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 2ed0c55 into kcl-lang:main Jul 30, 2024
11 of 12 checks passed
@Peefy Peefy deleted the feat-override-union-config branch July 30, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zong-zhe zong-zhe zong-zhe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] OverrideFile API supports automatic merging of configuration compilation through the : operator
3 participants
@Peefy @coveralls @zong-zhe