Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove raw string prefix in the hover docs #1567

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Aug 14, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #1555

  • feat: remove raw string prefix in the hover docs

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 5b7bfce into kcl-lang:main Aug 14, 2024
11 of 12 checks passed
@Peefy Peefy deleted the remove-raw-str-prefix-in-hover-doc branch August 14, 2024 08:24
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10383747094

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 70.549%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/resolver/doc.rs 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/resolver/doc.rs 1 95.63%
Totals Coverage Status
Change from base Build 10383202330: -0.01%
Covered Lines: 50510
Relevant Lines: 71596

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Enhance KCL schema doc hover for the raw long string.
3 participants