Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip]refactor: refactor parser. parse kcl project by separate file #1625

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Sep 5, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@coveralls
Copy link
Collaborator

coveralls commented Sep 23, 2024

Pull Request Test Coverage Report for Build 11327621119

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 696 of 767 (90.74%) changed or added relevant lines in 11 files are covered.
  • 272 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.2%) to 70.364%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runner/src/lib.rs 0 1 0.0%
kclvm/parser/src/file_graph.rs 83 114 72.81%
kclvm/parser/src/lib.rs 593 632 93.83%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/request.rs 3 64.97%
kclvm/tools/src/LSP/src/state.rs 7 83.86%
kclvm/tools/src/LSP/src/dispatcher.rs 7 65.71%
kclvm/sema/src/advanced_resolver/node.rs 46 84.65%
kclvm/parser/src/lib.rs 209 73.96%
Totals Coverage Status
Change from base Build 11304430960: -0.2%
Covered Lines: 51795
Relevant Lines: 73610

💛 - Coveralls

@He1pa He1pa added parser Issues or PRs related to kcl parser refactor labels Sep 23, 2024
@He1pa He1pa force-pushed the refactor_parser branch 5 times, most recently from 8263f7d to 1dede3e Compare September 25, 2024 04:05
He1pa and others added 3 commits October 14, 2024 15:48
Signed-off-by: he1pa <[email protected]>
Signed-off-by: he1pa <[email protected]>
Signed-off-by: he1pa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parser Issues or PRs related to kcl parser refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants