Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: pkg import error message #1631

Merged
merged 1 commit into from
Sep 9, 2024
Merged

refactor: pkg import error message #1631

merged 1 commit into from
Sep 9, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Sep 9, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix kcl-lang/modules#123", "re kcl-lang/modules#123".):

  • N
  • Y

re #1686

refactor: pkg import error message

zong-zhe
zong-zhe approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

He1pa
He1pa approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link
Collaborator

coveralls commented Sep 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10768647049

Details

  • 33 of 33 (100.0%) changed or added relevant lines in 7 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.001%) to 70.737%
Files with Coverage Reduction New Missed Lines %
kclvm/parser/src/lib.rs 1 96.48%
kclvm/tools/src/LSP/src/inlay_hints.rs 3 92.31%
Totals Coverage Status
Change from base Build 10737503781: 0.001%
Covered Lines: 51250
Relevant Lines: 72451
💛 - Coveralls

@Peefy Peefy merged commit d5f4a27 into kcl-lang:main Sep 9, 2024
12 checks passed
@Peefy Peefy deleted the refactor-pkg-import-err-msg branch September 9, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@He1pa He1pa He1pa approved these changes

@zong-zhe zong-zhe zong-zhe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Peefy @coveralls @He1pa @zong-zhe