Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for taking mod relative paths as input. #622

Merged
merged 3 commits into from
Jul 26, 2023
Merged

feat: support for taking mod relative paths as input. #622

merged 3 commits into from
Jul 26, 2023

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix issue #572

2. What is the scope of this PR (e.g. component or file name):

kclvm/config/

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

Now, the following commands is supported to compile the kcl pacakges with different kcl.mod files.

kcl /usr/my_kcl/main.k ${other_pkg:KCL_MOD}/main.k -E other_pkg=/usr/other_pkg

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the enhancement New feature or request label Jul 25, 2023
@zong-zhe zong-zhe added this to the v0.6.0 Release milestone Jul 25, 2023
@zong-zhe zong-zhe self-assigned this Jul 25, 2023
@coveralls
Copy link
Collaborator

coveralls commented Jul 26, 2023

Pull Request Test Coverage Report for Build 5665661844

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.988%

Totals Coverage Status
Change from base Build 5664325114: 0.0%
Covered Lines: 2300
Relevant Lines: 2614

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! LGTM!

@Peefy Peefy merged commit 1829787 into kcl-lang:main Jul 26, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants