feat: impossible comparison #148
Open
+538
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xLucqs
requested changes
Oct 17, 2024
Comment on lines
+661
to
+682
| pub fn fix_impossible_comparison(&self, db: &dyn SyntaxGroup, node: SyntaxNode) -> Option<(SyntaxNode, String)> { | ||
| let expr_if = ExprIf::from_syntax_node(db, node.clone()); | ||
| let indent = expr_if.if_kw(db).as_syntax_node().get_text(db).chars().take_while(|c| c.is_whitespace()).count(); | ||
|
|
||
| match expr_if.else_clause(db) { | ||
| OptionElseClause::Empty(_) => Some(( | ||
| node, | ||
| indent_snippet(&format!("if false {}", expr_if.if_block(db).as_syntax_node().get_text(db)), indent / 4), | ||
| )), | ||
| OptionElseClause::ElseClause(else_clause) => Some(( | ||
| node, | ||
| indent_snippet( | ||
| &format!( | ||
| "if false {}{}", | ||
| expr_if.if_block(db).as_syntax_node().get_text(db), | ||
| else_clause.as_syntax_node().get_text(db) | ||
| ), | ||
| indent / 4, | ||
| ), | ||
| )), | ||
| } | ||
| } |
There was a problem hiding this comment.
fix pas
if false {...} n'a pas de sens
| // Check is >= or > or < or <= | ||
| let full_name = func_call.function.full_name(db); | ||
| let logic_op = if full_name.contains("core::integer::") { | ||
| if full_name.contains("PartialOrd::gt") { |
There was a problem hiding this comment.
tu peux pas faire core::PartialOrd::gt ? et utiliser les constantes dans src/lib.rs ?
| ) -> Option<(String, &'static str, BigInt)> { | ||
| // Check is >= or > or < or <= | ||
| let full_name = func_call.function.full_name(db); | ||
| let logic_op = if full_name.contains("core::integer::") { |
There was a problem hiding this comment.
Suggested change
| let logic_op = if full_name.contains("core::integer::") { | |
| let logic_op = full_name.contains("core::integer::").then(|| { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #119
Catches 8 cases of impossible comparison :