Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip defaults on non zero values #179

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

davidterranova
Copy link

The goal of this PR is to apply defaults only if the two following conditions are matched :

  • No environment variable matches the struct field
  • The struct field value is the zero value

This change allow envconfig to be integrated with a more general config system that loads the config from a different provider and override values from environment variables if they are defined / with a zero value

@davidterranova davidterranova changed the title Skip default on non zero values Skip defaults on non zero values Aug 22, 2020
@draev
Copy link

draev commented Oct 15, 2020

Up! It's a useful fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants