Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

Move the values for the TOKENS into a secrets file #18

Open
robertjahn opened this issue Apr 20, 2020 · 0 comments
Open

Move the values for the TOKENS into a secrets file #18

robertjahn opened this issue Apr 20, 2020 · 0 comments

Comments

@robertjahn
Copy link
Collaborator

Move these values that are now in notification-service.yaml into a k8 secrets file will make them more secure. So change code and instructions in readme.

        env:
        - name: TEAMS_URL
          value: ""
        - name: BRIDGE_URL
          value: ""
        - name: SLACK_URL
          value: ""
        - name: WEBEXTEAMS_URL
          value: ""

Plus you can have the benefit of deploying the service without having to clone the repo, for example kubectl apply -f https://raw.githubusercontent.com/keptn-contrib/notification-service/master/deploy/notification-service.yaml

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant