Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maven2sbt v1.5.0 #342

Merged
merged 1 commit into from
Jul 12, 2023
Merged

maven2sbt v1.5.0 #342

merged 1 commit into from
Jul 12, 2023

Conversation

kevin-lee
Copy link
Owner

maven2sbt v1.5.0

1.5.0 - 2023-07-12

Bug Fix

Improvement

  • Exclude should not have Scala binary version suffix (Exclude should not have Scala binary version suffix #327)

    The old exclusions look like

    exclude("group-id", "artifact-id_${props.scalaBinaryVersion}")
    excludeAll(
      ExclusionRule(organization = "group-id", name = "artifact-id_${props.scalaBinaryVersion}"),
      ExclusionRule(organization = "group-id2", name = "artifact-id2"),
    )

    It is now done like these instead.

    excludeAll("group-id" %% "artifact-id")
    excludeAll(
      "group-id" %% "artifact-id",
      "group-id2" % "artifact-id2",
    )

    It is much cleaner this way.

  • Make GlobalSettings.empty constant (Make GlobalSettings.empty constant #285)

    Make GlobalSettings.empty constant.
    GlobalSettings.empty is currently def so it creates a new instance of an empty GlobalSettings whenever GlobalSettings.empty is called. However, GlobalSettings is immutable so there can be only one instance used for any required empty GlobalSettings.

Internal Housekeeping

@kevin-lee kevin-lee added this to the milestone11 milestone Jul 12, 2023
@kevin-lee kevin-lee self-assigned this Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (06754e3) 59.00% compared to head (5f36898) 59.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #342   +/-   ##
=======================================
  Coverage   59.00%   59.00%           
=======================================
  Files          28       28           
  Lines         505      505           
  Branches       86       86           
=======================================
  Hits          298      298           
  Misses        207      207           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kevin-lee kevin-lee merged commit eef734b into main Jul 12, 2023
12 checks passed
@kevin-lee kevin-lee deleted the prepare-to-release branch July 12, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant