-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[>=4.4.0] Uploading file with aiohttp seems broken: TypeError: cannot pickle '_io.BufferedReader' object #737
Comments
Hi @LilSpazJoekp is my understanding correct that this worked with 4.3.0 for you previously? I'm not sure right now what we can do about these requests not being deepcopy-able. Maybe catch the exception and continue with the original — not sure how bad of an idea that is. |
No this worked with 4.2.1 and stopped working with 4.3.0 and on. |
Correction. Not working on 4.3.0 was due to urllib3 issues. After fixing those this worked on 4.3.0 but not on 4.4.0. |
@LilSpazJoekp I see, thanks for the clarification 👍 |
@LilSpazJoekp potentially important to know: If this is fixed it will be fixed in a release VCR.py >=5.0.1 with support for >=Python 3.8 only. Your CI shows still shows use of end-of-life Python 3.7 which is why I'm bringing this up. |
That's fine. We plan on dropping 3.7 soon. I thought EOL was later in the year. |
When uploading files with aiohttp, the following error occurs.
Suspect commit.
Error
aiohttp code to reproduce:
See failed tests here: https:/praw-dev/asyncpraw/pull/246/checks#step:6:5393
The text was updated successfully, but these errors were encountered: