Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gssoc'21] Added the Password validations in front-end #135

Merged
merged 2 commits into from
Mar 30, 2021
Merged

[Gssoc'21] Added the Password validations in front-end #135

merged 2 commits into from
Mar 30, 2021

Conversation

arpit456jain
Copy link
Contributor

Related Issuse

  • Info about Issue or bug
    Its very frustrating to get error message for password after signing up "and after waiting for 3-4 sec for ending pre-loader "

Closes: #126 #127

Describe the changes you've made

I had added the java script for these validations and some CSS for its cool display.
It is looking like this.

I had corrected the spelling mistake changed "forget" to "forgot"

elektra.mp4

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

Screenshots

Original Updated
original screenshot updated screenshot

@arpit456jain
Copy link
Contributor Author

@khannakshat7 please review it and add labels before merging

@khannakshat7 khannakshat7 added good first issue Good for newcomers gssoc21 GSSOC 21 Level3 labels Mar 30, 2021
@khannakshat7 khannakshat7 merged commit 156d81b into khannakshat7:master Mar 30, 2021
@khannakshat7
Copy link
Owner

@arpit456jain Good contribution !!
Don't forget to ⭐ the repo and follow us on GitHub.

@arpit456jain
Copy link
Contributor Author

@arpit456jain Good contribution !!
Don't forget to ⭐ the repo and follow us on GitHub.

Sure @khannakshat7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers gssoc21 GSSOC 21 Level3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Gssoc'21] Password validation in front-end by JavaScript.
2 participants