Skip to content

Commit

Permalink
[8.x] [ResponseOps][Rules] Rule type selection modal content cut off …
Browse files Browse the repository at this point in the history
…on small screens due to lack of vertical scrolling (elastic#195234) (elastic#195543)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ResponseOps][Rules] Rule type selection modal content cut off on
small screens due to lack of vertical scrolling
(elastic#195234)](elastic#195234)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https:/sqren/backport)

<!--BACKPORT [{"author":{"name":"Georgiana-Andreea
Onoleață","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-09T08:22:57Z","message":"[ResponseOps][Rules]
Rule type selection modal content cut off on small screens due to lack
of vertical scrolling (elastic#195234)\n\n## Summary\r\n\r\nCloses
https:/elastic/kibana/issues/184048\r\n\r\n- the rule type
selection modal is now scrollable on smaller windows
\r\n\r\n\r\nhttps:/user-attachments/assets/47082b35-02a7-4b67-9a88-ee4200908bef\r\n\r\nCo-authored-by:
Antonio
<[email protected]>","sha":"6df672421d6df47cb3e8f86ab9448f021dabc871","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[ResponseOps][Rules]
Rule type selection modal content cut off on small screens due to lack
of vertical
scrolling","number":195234,"url":"https:/elastic/kibana/pull/195234","mergeCommit":{"message":"[ResponseOps][Rules]
Rule type selection modal content cut off on small screens due to lack
of vertical scrolling (elastic#195234)\n\n## Summary\r\n\r\nCloses
https:/elastic/kibana/issues/184048\r\n\r\n- the rule type
selection modal is now scrollable on smaller windows
\r\n\r\n\r\nhttps:/user-attachments/assets/47082b35-02a7-4b67-9a88-ee4200908bef\r\n\r\nCo-authored-by:
Antonio
<[email protected]>","sha":"6df672421d6df47cb3e8f86ab9448f021dabc871"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https:/elastic/kibana/pull/195234","number":195234,"mergeCommit":{"message":"[ResponseOps][Rules]
Rule type selection modal content cut off on small screens due to lack
of vertical scrolling (elastic#195234)\n\n## Summary\r\n\r\nCloses
https:/elastic/kibana/issues/184048\r\n\r\n- the rule type
selection modal is now scrollable on smaller windows
\r\n\r\n\r\nhttps:/user-attachments/assets/47082b35-02a7-4b67-9a88-ee4200908bef\r\n\r\nCo-authored-by:
Antonio
<[email protected]>","sha":"6df672421d6df47cb3e8f86ab9448f021dabc871"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Georgiana-Andreea Onoleață <[email protected]>
  • Loading branch information
kibanamachine and georgianaonoleata1904 authored Oct 9, 2024
1 parent ef3ebf0 commit 30db970
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ export const RuleTypeList: React.FC<RuleTypeListProps> = ({
grow={1}
style={{
paddingTop: euiTheme.size.base /* Match drop shadow padding in the right column */,
paddingRight: euiTheme.size.base,
overflowY: 'auto',
}}
>
<EuiFacetGroup>
Expand Down

0 comments on commit 30db970

Please sign in to comment.