Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Windows 10 versions #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

New Windows 10 versions #23

wants to merge 1 commit into from

Conversation

jveazey
Copy link

@jveazey jveazey commented Nov 14, 2022

  1. Added full version number for Windows 10 version 21h2 as a comment
  2. Added Windows 10 version 22h2. (This shares a feature update value with Windows 11. So, I left it as a "?"; same as Windows 11 RTM)
  3. Added Windows Server 2022. Not sure if it goes here; but it has it's own WaaS build number, unlike Windows Server 2016 (1607) and Windows Server 2019 (1809). 3a. The codename "Iron" comes from here (https://en.wikipedia.org/wiki/List_of_Microsoft_codenames#Windows_NT_family), but the feature update is shown as 21H2.
  4. Added Windows 11 2023 update. I commented it out since it's still an insider build.

I'm curious how you'd like to handle duplicate feature update and codename values, since it looks like Microsoft will continue to share update names between Windows 10 and Windows 11 (ex. 21H2, 22H2)

1. Added full version number for Windows 10 version 21h2 as a comment
2. Added Windows 10 version 22h2. (This shares a feature update value with Windows 11. So, I left it as a "?"; same as Windows 11 RTM)
3. Added Windows Server 2022. Not sure if it goes here; but it has it's own WaaS build number, unlike Windows Server 2016 (1607) and Windows Server 2019 (1809). 
3a. The codename "Iron" comes from here (https://en.wikipedia.org/wiki/List_of_Microsoft_codenames#Windows_NT_family), but the feature update is shown as 21H2.
4. Added Windows 11 2023 update. I commented it out since it's still an insider build.

I'm curious how you'd like to handle duplicate feature update and codename values, since it looks like Microsoft will continue to share update names between Windows 10 and Windows 11 (ex. 21H2, 22H2)
@sredna
Copy link
Collaborator

sredna commented Nov 25, 2022

I don't know what to do about the shared names other than always mapping to the newest Windows. The old platform is dead, at least in terms of features you'd need to test for in a installer.

Why is your build number for SV3 lower than what we have for SV2?

@jveazey
Copy link
Author

jveazey commented Nov 28, 2022

Why is your build number for SV3 lower than what we have for SV2?

My mistake, the latest beta build has the major build number 25247, but that's not going to be the final major build number (https://pureinfotech.com/windows-11-insider-preview-build-history). So, maybe we should just keep that blank for now. I have no idea where I got that original major build number.

It's strange that Windows 11 is incrementing the major build so much, since Windows 10 only increased the major build by 1 on each fa release (19044 for 21H2, 19045 for 22H2).

Related note. I just found this when googling. The Windows 11 23XX release has the code name Nickel, instead of Sun Valley 3 (https://www.neowin.net/news/windows-11-22h2-is-almost-cooked-suggests-a-leaked-internal-script-for-insiders/).

I don't know what to do about the shared names other than always mapping to the newest Windows

I'm wondering if we can rename the fa names as 11.XXXX. So, 11.21H2 and 11.22H2. I'm not sure if (or how) it would break macros that check ${fu}. The ${marketingname} check would need a similar change.

Since there's already one macro with the fa name "?", I would be fairly confident that switching to that format could be a solution; but that's not my judgement call.

Question. how does ${AtLeastWaaS} == "21H1" work, anyway? Or is this broken?

@sredna
Copy link
Collaborator

sredna commented Nov 29, 2022

It's strange that Windows 11 is incrementing the major build so much, since Windows 10 only increased the major build by 1 on each fa release (19044 for 21H2, 19045 for 22H2).

Very few new features. Windows 10 was dead at this point with MS working on the failed 10X and then 11.

I'm wondering if we can rename the fa names as 11.XXXX. So, 11.21H2 and 11.22H2. I'm not sure if (or how) it would break macros that check ${fu}. The ${marketingname} check would need a similar change.

Since there's already one macro with the fa name "?", I would be fairly confident that switching to that format could be a solution; but that's not my judgement call.

I suppose 11.xxx would work but I'd rather just abandon extra names for 10 at this point, it is not going to get any new features installers care about. You can add support for any name you want by adding !macro WinVerExternal_WaaS_MapToBuild ignore text outputdefine to your .nsi.

Question. how does ${AtLeastWaaS} == "21H1" work, anyway? Or is this broken?

We only compare the build number, everything else just maps from text to a build number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants