Update Cargo.lock in remove, fix versions in tests
#780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cassaundra
commented
Sep 2, 2022
crates/cargo-remove/tests/testsuite/cargo_remove/remove-basic.in/Cargo.toml
Show resolved
Hide resolved
epage
reviewed
Sep 2, 2022
crates/cargo-remove/tests/testsuite/cargo_remove/remove_avoid_empty_tables/stderr.log
Show resolved
Hide resolved
|
Looks good outside of the two unresolved comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces functionality for
cargo removeto updateCargo.lock, like rust-lang/cargo#10902.As it turns out, the testing
Cargo.tomls contain a lot of package versions without mock equivalents. In order to facilitate the fix for this, tests were grouped into three base examples to be symlinked against. This was essentially a planned refactor that I had forgotten about anyway.