Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow retrieving data from metadata or adding data to metadata #45

Merged
merged 5 commits into from
Oct 10, 2024

Conversation

rogerogers
Copy link
Collaborator

允许从 metadata 获取信息、设置信息到 metadata

closed: cloudwego/kitex#1323

@rogerogers rogerogers closed this Apr 20, 2024
@rogerogers rogerogers deleted the feat/metadata-extractor branch April 20, 2024 07:24
@rogerogers rogerogers restored the feat/metadata-extractor branch April 20, 2024 07:25
@rogerogers rogerogers reopened this Apr 20, 2024
Signed-off-by: rogerogers <[email protected]>
Signed-off-by: rogerogers <[email protected]>
tracing/options.go Outdated Show resolved Hide resolved
Copy link
Member

@CoderPoet CoderPoet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@bytedance-oss-robot bytedance-oss-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CoderPoet, rogerogers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bytedance-oss-robot bytedance-oss-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2024
@CoderPoet CoderPoet merged commit c58c642 into main Oct 10, 2024
17 checks passed
@CoderPoet CoderPoet deleted the feat/metadata-extractor branch October 10, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Proposal: tracing.ServerMiddleware 同时支持 metainfo 和 metadata 协议读取
2 participants