RFC: Support Redis celery broker #213
Open
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmullen
commented
Oct 10, 2024
| """ | ||
|
|
||
| # Assume AMQP. | ||
| CELERY_BROKER_URL = values.Value("amqp://localhost:5672/") | ||
| CELERY_BROKER_URL = values.Value("redis://localhost:6379/0") |
There was a problem hiding this comment.
Resonant dev environments always set this value, so the default isn't really important.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As written, the change here in the
_HerokuMixinis backwards incompatible and will break any installations using CloudAMQP rather than the Redis addon. If we wanted a backward compatible version of this, we'd need fallback logic (likely in a@property) to check for either environment variable (with some order of precedence we could decide on).For local development, no code changes are needed in this library to support using redis as the broker.
Note also that this PR doesn't go as far as to enable a celery results backend. If we switch to Redis, it's officially more suitable as a result backend than AMQP, but that's a more controversial change than I want for the scope of this RFC.