Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zstd: explicitly disable checksum checking #571

Closed
WojciechMula opened this issue Apr 26, 2022 · 2 comments · Fixed by #572
Closed

zstd: explicitly disable checksum checking #571

WojciechMula opened this issue Apr 26, 2022 · 2 comments · Fixed by #572

Comments

@WojciechMula
Copy link
Contributor

WojciechMula commented Apr 26, 2022

This is follow up of #556. In short: we're decompressing the same files over and over. We measured that checksumming takes ~15% of decompression time. We want to conditionally perform checksumming (likely: for the first time).

Would it be possible to add an option to the decoder, like WithChecksum(false)?

@klauspost
Copy link
Owner

Yes, sounds reasonable. I would rather have it be IgnoreChecksum(true), but that is a detail.

@WojciechMula
Copy link
Contributor Author

Great! I will prepare a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants