Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated CreateHeaderRaw to correctly call CreateRaw #502

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

saracen
Copy link
Contributor

@saracen saracen commented Feb 21, 2022

fastzip had reports of malformed compressed data (saracen/fastzip#32). I've narrowed the fix down to this.

I'll update fastzip to call the non-deprecated function now, but fixing this here is still a good idea. gitLab-runner uses fastzip and stumbled across this issue when the klauspost/compress dependency was indirectly updated via a minor minio upgrade. 😢

saracen added a commit to saracen/fastzip that referenced this pull request Feb 21, 2022
This also now calls the newer CreateRaw() method, as CreateHeaderRaw() is now
deprecated.

This fixes #32, as when CreateHeaderRaw() was deprecated, it started calling the
incorrect function that replaced it:
klauspost/compress#502

A test with a larger content body has been added as it was able to detect this
regression.

Fixes #32
@klauspost
Copy link
Owner

Thanks for the contrib.

@klauspost klauspost merged commit ad9ff7c into klauspost:master Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants