Fix memoizeWrap when displayName is null #654
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component.displayName
can be undefined for release builds which means a bunch of components will fight for the undefined key. In my app it results in theSwitch
component rendering nothing (or probably just another component likeScrollView
).To fix this I use the component class as the key in a
WeakMap
instead. I also added a null check since some components are being removed from RN core like ToolbarAndroid so it makesmemoizeWrap
safe in those cases.